Posted by: Rob_BAM - Thursday, 18 February 2016 02:41:16 |
---|
Here is my brand new forum based on yaf.net 2.2.3 beta with some customizations: [url=http://highfatlowcarbliving.com]High Fat Low Carb Living[/url] It's responsive to work well on both small and large screens: It also includes some URL rewriting changes such as forum name in the URL. Other than that, it has some other small tweaks, mostly in CSS. Thanks for a great forum software! Robert |
Posted by: Zero2Cool - Thursday, 18 February 2016 20:51:49 |
---|
Very nicely done! Could you do a Pull Request with the changes you made for responsive layout? That would be HUGE for the YAF community. It's the biggest pain point for users currently. https://github.com/YAFNET/YAFNET |
Posted by: Rob_BAM - Friday, 19 February 2016 05:28:17 |
---|
Thanks, I haven't really used GitHub before other than downloading code. I would do "new pull request", apply the changes and check it back in? |
Posted by: Zero2Cool - Friday, 19 February 2016 14:34:06 |
---|
[quote=Rob_BAM;66618]Thanks, I haven't really used GitHub before other than downloading code. I would do "new pull request", apply the changes and check it back in?[/quote] Yep, I believe so. I haven't done one in awhile so I'm not sure. And if the Lead Developer approves of the changes, they will merge the pull. |
Posted by: Rob_BAM - Friday, 19 February 2016 21:55:24 |
---|
OK, I'll give it a try next week when I have the time. |
Posted by: Rob_BAM - Thursday, 25 February 2016 16:39:26 |
---|
Trying to create new pull request allows me to only compare master to bootstrap branch. I think I would need a branch that I can apply the responsive layout to. I don't see a way to create one myself. I've made other custom changes specific for my forum so I would not want to check those in. Can somebody create a new branch from master or let me know where I should apply those changes? |
Posted by: bbobb - Thursday, 25 February 2016 20:57:58 |
---|
https://help.github.com/articles/using-pull-requests/ |
Posted by: Rob_BAM - Friday, 26 February 2016 19:47:06 |
---|
I just checked in the changes that I did for my forum to make YAF.NET responsive here: https://github.com/Redyta/YAFNET Take a look and let me know if there are any issues with running it. I only applied theme changes to BlackGrey theme. To make responsive work with images, I made some changes so they stretch to width. There is an issue with small images that get starched so they don't look good but I didn't want to spend more time on that. Also, signature gets displayed right after message instead of bottom of the row. Again, I didn't want to spend time on that. Other than that, the main pages of BlackGrey theme should look OK on all devices. |