YAFLogo

tha_watcha
  • tha_watcha
  • 100% (Exalted)
  • YAF.NET Project Lead 🤴 YAF Version: 3.0.3
8 years ago
Originally Posted by: coral 

Many thanks for your quick reply.

Originally Posted by: tha_watcha 

at some point you should create a fork of your changes, or you will never able to upgrade.

I am not familiar with fork. Can you explain a bit more please? How I can do it? Is there any special tools for that?

There is a basic guide on what a fork is and how to do a fork

https://help.github.com/articles/fork-a-repo 

What is basically does it clones the YAFNET repository and creates your own, where you can check in your own code modifications. And of course it allows you to sync your repository with the YAFNET repository, to always get the latest code.

The easiest to for managing git on your pc is proberly GitHub for Windows 

Zero2Cool
8 years ago
With YAF maintaining everything the same with bootstrap and my desire to tweak a few things with forumlist/topiclist/postlist display instead, a fork for what I want might be a great idea. That's exciting!!
salma
  • salma
  • 54.8% (Neutral)
  • YAF Forumling
8 years ago
hi friends.

i have the same problem but the version that i installed is 1.9.6.1.

there is a problem with verification emails.

The content of emails include very strange characters and therefore can not be read by users(in yahoomail like chines in gmail like the image below).

the language that i'm using is persian(farsi).

thank you for your help.:)

coral
  • coral
  • 72% (Friendly)
  • YAF Lover
8 years ago
Originally Posted by: tha_watcha 

Originally Posted by: coral 

Could you please tell me which file and part of code must be changed so I can fix it myself.

many thanks.

here...

https://github.com/YAFNET/YAFNET/commit/503b5dab388b76488b692d98afdf937e6b2fa9bc 

I made the changes and the body of email is fine now but To and From are still in strange character. The forum language is Farsi.

tha_watcha
  • tha_watcha
  • 100% (Exalted)
  • YAF.NET Project Lead 🤴 YAF Version: 3.0.3
8 years ago
Originally Posted by: coral 

Originally Posted by: tha_watcha 

Originally Posted by: coral 

Could you please tell me which file and part of code must be changed so I can fix it myself.

many thanks.

here...

https://github.com/YAFNET/YAFNET/commit/503b5dab388b76488b692d98afdf937e6b2fa9bc 

I made the changes and the body of email is fine now but To and From are still in strange character. The forum language is Farsi.

Apply my latest commit, now it should work correctly

https://github.com/YAFNET/YAFNET/commit/5a6476b5e671d7b40d235406e89e8a16a4e4916d 

coral
  • coral
  • 72% (Friendly)
  • YAF Lover
8 years ago

Am I right that for solving this problem the only neccessory changes that sould be made is adding following three lines to Populate method of MailMessageExtensions (Located in \YAF.Core\Extensions\MailMessageExtensions.cs)???

mailMessage.HeadersEncoding = Encoding.UTF8;
            mailMessage.BodyEncoding = Encoding.UTF8;
            mailMessage.SubjectEncoding = Encoding.UTF8;

or other changes needed as well?

tha_watcha
  • tha_watcha
  • 100% (Exalted)
  • YAF.NET Project Lead 🤴 YAF Version: 3.0.3
8 years ago
No other changes, just compile
coral
  • coral
  • 72% (Friendly)
  • YAF Lover
8 years ago
Then it must be a few more files to change as well. when I compile it there are some compiler errors like

YAF.Core.Services.YafSendMail' does not implement interface member 'YAF.Types.Interfaces.ISendMail.SendAllIsolated(System.Collections.Generic.IEnumerable, System.Action)'

'YAF.Core.Services.YafSendMail' does not implement interface member 'YAF.Types.Interfaces.ISendMail.SendAll(System.Collections.Generic.IEnumerable)'

and when I change the IsendMail interface then there is other compiler errors.

I think I have to change more than those 7 files mentioned in the link.

tha_watcha
  • tha_watcha
  • 100% (Exalted)
  • YAF.NET Project Lead 🤴 YAF Version: 3.0.3
8 years ago
Originally Posted by: coral 

Then it must be a few more files to change as well. when I compile it there are some compiler errors like

YAF.Core.Services.YafSendMail' does not implement interface member 'YAF.Types.Interfaces.ISendMail.SendAllIsolated(System.Collections.Generic.IEnumerable, System.Action)'

'YAF.Core.Services.YafSendMail' does not implement interface member 'YAF.Types.Interfaces.ISendMail.SendAll(System.Collections.Generic.IEnumerable)'

and when I change the IsendMail interface then there is other compiler errors.

I think I have to change more than those 7 files mentioned in the link.

only add this 3 lines of code and it should compile with your version

coral
  • coral
  • 72% (Friendly)
  • YAF Lover
8 years ago
adding only those three lines didn't solve the problem. It seems I have to find all the files that needs upgrading.
coral
  • coral
  • 72% (Friendly)
  • YAF Lover
8 years ago
To sum up I upgraded the following fies and everything is fine now

yafsrc/YetAnotherForum.NET/install/default.aspx.cs

yafsrc/YAF.Types/Extensions/StringExtensions.cs

yafsrc/YAF.Core/Services/YafTemplateEmail.cs

yafsrc/YAF.Core/Services/YafSendMail.cs

yafsrc/YAF.Core/Services/YafDigest.cs

yafsrc/YAF.Core/Extensions/MailMessageExtensions.cs

yafsrc/YAF.Core/Extensions/ISendMailExtensions.cs

yafsrc/YAF.Types/Interfaces/IsendMail.cs

yafsrc/YAF.Core/Services/YafSendMailThreaded.cs