YAFLogo

johans
  • johans
  • 51.8% (Neutral)
  • YAF Lover Topic Starter
11 years ago
I found two DisplayName bugs. I've checked against revision 5379.

cp_message.ascx.cs line 193:
Quote:

this.PageLinks.AddLink(this.PageContext.PageUserName, YafBuildLink.GetLink(ForumPages.cp_profile));


should be:
Quote:

this.PageLinks.AddLink(this.PageContext.BoardSettings.EnableDisplayName
? this.PageContext.CurrentUserData.DisplayName : this.PageContext.PageUserName, YafBuildLink.GetLink(ForumPages.cp_profile));



YafSendNotification.cs line 261:

Quote:

var emailSubject =
this.Get().GetText(
"COMMON", "PM_NOTIFICATION_SUBJECT", languageFile).FormatWith(
YafContext.Current.PageUserName, this.Get().Name, subject);


should be:
Quote:

var emailSubject =
this.Get().GetText(
"COMMON", "PM_NOTIFICATION_SUBJECT", languageFile).FormatWith(
displayName.IsNotSet() ? YafContext.Current.PageUserName : displayName, this.Get().Name, subject);

Sponsor

tha_watcha
  • tha_watcha
  • 100% (Exalted)
  • YAF.NET Project Lead 🤴 YAF Version: 3.0.3
11 years ago
thanks fixed.
johans
  • johans
  • 51.8% (Neutral)
  • YAF Lover Topic Starter
11 years ago
Found some more in:
cp_changepassword.ascx.cs
cp_editavatar.ascx.cs
cp_editprofile.ascx.cs
cp_message.ascx.cs
cp_signature.ascx.cs
cp_subscriptions.ascx.cs

Edit: When clicking the "Thank" button in a post (DisplayPost.ascx), Name is shown instead of DisplayName.
It seems the WS call to AddThanks in YafAjax.cs uses the name returned from the sproc "message_addthanks", which is hard coded to use name instead of looking at board setting.
tha_watcha
  • tha_watcha
  • 100% (Exalted)
  • YAF.NET Project Lead 🤴 YAF Version: 3.0.3
11 years ago
Originally Posted by: johans 

Found some more in:
cp_changepassword.ascx.cs
cp_editavatar.ascx.cs
cp_editprofile.ascx.cs
cp_message.ascx.cs
cp_signature.ascx.cs
cp_subscriptions.ascx.cs

Edit: When clicking the "Thank" button in a post (DisplayPost.ascx), Name is shown instead of DisplayName.
It seems the WS call to AddThanks in YafAjax.cs uses the name returned from the sproc "message_addthanks", which is hard coded to use name instead of looking at board setting.



Should be fixed now.
YAF Logo Copyright © YetAnotherForum.NET & Ingo Herbote. All rights reserved
About Us

The YAF.NET is an open source .NET forum project. YAF.NET is supported by an team of international developers who are build community by building community software.

Powered by Resharper Donate with PayPal button