Reset Password · YAF.NET Support Forum

Welcome Guest! To enable all features please Login or Register

Posted by: RichP714 - Wednesday, 12 May 2010 02:16:02

I was looking into some of the ascx pages, doing some modifications, and I came across a couple of 'non well formed' lines in /controls/ForumCategoryList.ascx line 29 error: the tag was not close before this tag line 56

error: marked invalid because it is a mismatched end tag I shuffled things around and got a well formed page: line 8 (table opening) cut and replace on line 6 (right after ) line 56 (table ending) cut and replace on line 55 (right after ) this encloses the HeaderTemplate and asp:Repeater within the table tags. Besides now being a 'well formed' document, I found a considerable increase in forum response.

Posted by: componentsoft - Saturday, 22 May 2010 16:08:42
Like this. We also see the improvement after applying this patch

Posted by: herman_herman - Sunday, 23 May 2010 02:50:32
There are also some other malformed tags as far as I remember.I even fixed them in SVN sometime ago!

Posted by: bbobb - Sunday, 23 May 2010 05:43:17
[quote=herman_herman]There are also some other malformed tags as far as I remember.I even fixed them in SVN sometime ago![/quote] You'll be shocked but the thing originates in MSDN. It has a lot of examples which contain the error. I think it was originally related to DataGrid etc. style things and was copied everywhere by 'botcoders'.

Posted by: herman_herman - Sunday, 23 May 2010 12:43:33
[quote=bbobb][quote=herman_herman]There are also some other malformed tags as far as I remember.I even fixed them in SVN sometime ago![/quote] You'll be shocked but the thing originates in MSDN. It has a lot of examples which contain the error. I think it was originally related to DataGrid etc. style things and was copied everywhere by 'botcoders'.[/quote] Interesting..:shock:

Posted by: BWG - Sunday, 23 May 2010 19:22:14
Why is it malformed? The open table tag is in the HeaderTemplate and the close table tag is in the Footer template. Looks correct to me. :? Even if there was a malformed table tag it would be unlikely to have a big impact on performance IMO.

Posted by: RichP714 - Sunday, 23 May 2010 23:46:04
it would render correctly, yes, but wouldn't pass html validation, so I'm guessing the browser engine stutters on it a bit. IIRC the 'error' is that the table tag should be closed before the headertemplate tag in order to be a well formed html doc. The browser eventually sorts it out, but making it well formed there's less to think about for the engine. If you move things around as in my above post, the table encloses the HeaderTemplate and asp:Repeater fixing it seems to have made the page loads quicker

Posted by: RichP714 - Sunday, 23 May 2010 23:46:04

it would render correctly, yes, but wouldn't pass html validation, so I'm guessing the browser engine stutters on it a bit. IIRC the 'error' is that the table tag should be closed before the headertemplate tag in order to be a well formed html doc. The browser eventually sorts it out, but making it well formed there's less to think about for the engine. If you move things around as in my above post, the table encloses the HeaderTemplate and asp:Repeater fixing it seems to have made the page loads quicker

Posted by: Jaben - Monday, 24 May 2010 12:00:01
[quote=RichP714]it would render correctly, yes, but wouldn't pass html validation, so I'm guessing the browser engine stutters on it a bit. IIRC the 'error' is that the table tag should be closed before the headertemplate tag in order to be a well formed html doc. The browser eventually sorts it out, but making it well formed there's less to think about for the engine. If you move things around as in my above post, the table encloses the HeaderTemplate and asp:Repeater fixing it seems to have made the page loads quicker[/quote] It doesn't pass HTML validation? Please show me where you see that... All rendered pages have been tested again HTML Tidy and validate.

Posted by: Jaben - Monday, 24 May 2010 12:00:01

[quote=RichP714]it would render correctly, yes, but wouldn't pass html validation, so I'm guessing the browser engine stutters on it a bit. IIRC the 'error' is that the table tag should be closed before the headertemplate tag in order to be a well formed html doc. The browser eventually sorts it out, but making it well formed there's less to think about for the engine. If you move things around as in my above post, the table encloses the HeaderTemplate and asp:Repeater fixing it seems to have made the page loads quicker[/quote] It doesn't pass HTML validation? Please show me where you see that... All *rendered* pages have been tested again HTML Tidy and validate.

Posted by: bbobb - Monday, 24 May 2010 12:47:24
It validates. Anyway, I changed it in the svn source code just in case. The thing's harmless in the case. It's within an UpdatePanel, maybe something is related to this, when server-side tags are rendered. But I can't see any differences.

Posted by: RichP714 - Monday, 24 May 2010 23:13:40
[quote=Jaben][quote=RichP714]it would render correctly, yes, but wouldn't pass html validation, so I'm guessing the browser engine stutters on it a bit. IIRC the 'error' is that the table tag should be closed before the headertemplate tag in order to be a well formed html doc. The browser eventually sorts it out, but making it well formed there's less to think about for the engine. If you move things around as in my above post, the table encloses the HeaderTemplate and asp:Repeater fixing it seems to have made the page loads quicker[/quote] It doesn't pass HTML validation? Please show me where you see that... All rendered pages have been tested again HTML Tidy and validate.[/quote] when open in Microsoft expression, those lines are red with a 'squiggly' underline; if you hover the mouse over them, they say the errors I typed (basically that some tag was 'spanning' another tag, and should be enclosed by it). After moving things around as above, the 'error' goes away.

Posted by: RichP714 - Monday, 24 May 2010 23:13:40

[quote=Jaben][quote=RichP714]it would render correctly, yes, but wouldn't pass html validation, so I'm guessing the browser engine stutters on it a bit. IIRC the 'error' is that the table tag should be closed before the headertemplate tag in order to be a well formed html doc. The browser eventually sorts it out, but making it well formed there's less to think about for the engine. If you move things around as in my above post, the table encloses the HeaderTemplate and asp:Repeater fixing it seems to have made the page loads quicker[/quote] It doesn't pass HTML validation? Please show me where you see that... All *rendered* pages have been tested again HTML Tidy and validate.[/quote] when open in Microsoft expression, those lines are red with a 'squiggly' underline; if you hover the mouse over them, they say the errors I typed (basically that some tag was 'spanning' another tag, and should be enclosed by it). After moving things around as above, the 'error' goes away.

Posted by: BWG - Sunday, 30 May 2010 23:41:59
Still think it was right originally in YAF, and that the table tags should not be moved outside of the Repeater control. :? Here's an example from the SDK. Note that the begin and end table tags are inside the repeater control, in the Header and Footer templates. http://quickstarts.asp.net/QuickStartv20/util/srcview.aspx?path=~/aspnet/samples/ctrlref/data/repeater/Repeater2.src

Important Information: