YAFLogo

Kamyar
  • Kamyar
  • 100% (Exalted)
  • YAF Developer Topic Starter
14 years ago
I logged in to yaf from FF and IE at the same time to test the online status indicators. It seems like they are not getting configured correctly. after tracing, I found out that I should replace this:

DataTable activeUsers = PageContext.Cache.GetItem<DataTable>( cacheKey,
								YafContext.Current.BoardSettings.
								OnlineStatusCacheTimeout,
							() =>
							        DB.active_list(
								YafContext.Current.PageBoardID, false,
								YafContext.Current.BoardSettings.
								ActiveListTime, false ) );
with this:

DataTable activeUsers = DB.active_listtopic(PageContext.PageTopicID);
I have tested it and it works correctly with this modification.
If at first you don’t succeed, call it version 1.0
Sponsor
bbobb
  • bbobb
  • 100% (Exalted)
  • YAF Developer
14 years ago
active_listtopic can't be used here:wink: . The data should be cached from active_list. And you can't use it here directly by performancе reasons.

Cache time there should be very short and max seconds but not minutes.

Current generic doesn't allow it.

Kamyar
  • Kamyar
  • 100% (Exalted)
  • YAF Developer Topic Starter
14 years ago
Well, it seems strange that when I log on to the forum, The indicator is "Offline" for me. I don't know much about caching but I think I waited enough to see the online statuses change and they didn't.


If at first you don’t succeed, call it version 1.0
bbobb
  • bbobb
  • 100% (Exalted)
  • YAF Developer
14 years ago
The cache piece was changed by Jaben in r.2828. I didn't look into it, so far.

Update.

It works. The problem with cache time - it was milliseconds previously and set to 100 in board settings. I'll change it. But you can't check it if you open the messages in 2 browsers as you will be active before you close either brjavascript:__doPostBack('forum$ctl01$PostReply','')owser window.

Jaben
  • Jaben
  • 100% (Exalted)
  • YAF Developer
14 years ago
Easy to modify the GetItem function to take milliseconds...